make podman-clean-transient.service work as user #24421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the user session there is no boot-complete.target so the Requires= fails. We do not need it and I am not sure if we need it for the root unit either but I deicded to keep it there to not change anything and for the user session we patch it out. I patched this in the Makefile, while we could try to define two different source files for that it would make the Makefile logic even more complicated. In particular as this file is a .in we would need to add it to PODMAN_GENERATED_UNIT_FILES and then somehow fix the loop. To much work IMO so the sed trick to patch the user file is simpler. Fixes containers#23790 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the user session there is no boot-complete.target so the Requires= fails. We do not need it and I am not sure if we need it for the root unit either but I deicded to keep it there to not change anything and for the user session we patch it out.
I patched this in the Makefile, while we could try to define two different source files for that it would make the Makefile logic even more complicated. In particular as this file is a .in we would need to add it to PODMAN_GENERATED_UNIT_FILES and then somehow fix the loop. To much work IMO so the sed trick to patch the user file is simpler.
Fixes #23790
Does this PR introduce a user-facing change?